Create appkit manifest#484
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe default app URL used by ChangesDefault App URL and CI Validation Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/create-ton-appkit/src/index.ts`:
- Around line 200-205: The default app URL in the prompt has been updated to
https://appkit-template.vercel.app, but the template file
packages/create-ton-appkit/template-react/_env still contains the old
placeholder URL https://your-app.example.com/tonconnect-manifest.json which
creates inconsistency. Update the _env template file to use the same default URL
https://appkit-template.vercel.app so that users see a consistent example across
both the CLI prompt and the template configuration file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3841c09c-59b1-4022-af44-b8834f5d62da
📒 Files selected for processing (4)
.github/workflows/create_ton_appkit_test.ymlpackages/create-ton-appkit/README.mdpackages/create-ton-appkit/src/index.tspackages/create-ton-appkit/template-react/public/tonconnect-manifest.json
There was a problem hiding this comment.
🧹 Nitpick comments (2)
.github/workflows/create_ton_appkit_test.yml (2)
79-81: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winUse structural JSON checks instead of literal grep matching.
At Lines 80-81, formatting changes in
tonconnect-manifest.jsoncan fail CI even when values are correct.Suggested change
manifest="my-app/public/tonconnect-manifest.json" - grep -q "\"url\": \"$APP_URL\"" "$manifest" - grep -q "\"iconUrl\": \"$APP_URL/favicon.svg\"" "$manifest" + APP_URL="$APP_URL" node -e ' + const fs = require("fs"); + const manifest = JSON.parse(fs.readFileSync(process.argv[1], "utf8")); + const appUrl = process.env.APP_URL; + if (manifest.url !== appUrl || manifest.iconUrl !== `${appUrl}/favicon.svg`) { + process.exit(1); + } + ' "$manifest"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/create_ton_appkit_test.yml around lines 79 - 81, The grep commands at lines 80-81 perform brittle literal string matching on JSON content, which fails if the JSON is reformatted despite having correct values. Replace both grep commands with jq-based JSON structural validation that checks if the "url" field equals "$APP_URL" and "iconUrl" field equals "$APP_URL/favicon.svg" in the tonconnect-manifest.json file, ensuring the checks pass regardless of JSON formatting or whitespace changes.
69-69: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winAvoid suppressing install logs at Line 69.
If the tarball install fails, this step exits without actionable output, which makes matrix debugging harder.
Suggested change
- npm i "./$tname" >/dev/null 2>&1 + npm i "./$tname"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/create_ton_appkit_test.yml at line 69, Remove the output redirection suppression from the npm install command that uses the $tname variable. The current command redirects both stdout and stderr to /dev/null with >/dev/null 2>&1, which hides diagnostic information when the install fails. Delete this redirection at the end of the npm i "./$tname" command so that install logs and error messages are visible in the workflow output, making it easier to debug matrix test failures.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/create_ton_appkit_test.yml:
- Around line 79-81: The grep commands at lines 80-81 perform brittle literal
string matching on JSON content, which fails if the JSON is reformatted despite
having correct values. Replace both grep commands with jq-based JSON structural
validation that checks if the "url" field equals "$APP_URL" and "iconUrl" field
equals "$APP_URL/favicon.svg" in the tonconnect-manifest.json file, ensuring the
checks pass regardless of JSON formatting or whitespace changes.
- Line 69: Remove the output redirection suppression from the npm install
command that uses the $tname variable. The current command redirects both stdout
and stderr to /dev/null with >/dev/null 2>&1, which hides diagnostic information
when the install fails. Delete this redirection at the end of the npm i
"./$tname" command so that install logs and error messages are visible in the
workflow output, making it easier to debug matrix test failures.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3820b30b-2fc8-4599-bef9-8b09f3671242
📒 Files selected for processing (1)
.github/workflows/create_ton_appkit_test.yml
Summary by CodeRabbit
Documentation
https://appkit-template.vercel.appas the default App URL.Chores
urlandiconUrl(including favicon).Templates
https://appkit-template.vercel.app.